Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLM-RoBERTa model for TF2 #2454

Merged
merged 4 commits into from
Jan 29, 2020
Merged

Add XLM-RoBERTa model for TF2 #2454

merged 4 commits into from
Jan 29, 2020

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Jan 8, 2020

Hello,

I have implemented the XLM-RoBERTa model handling for Tensorflow 2.

@jplu
Copy link
Contributor Author

jplu commented Jan 8, 2020

There is a little incompatibility between isort and black apparently psf/black#251

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #2454 into master will increase coverage by 0.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2454     +/-   ##
=========================================
+ Coverage   74.51%   75.11%   +0.6%     
=========================================
  Files          87       88      +1     
  Lines       14920    14945     +25     
=========================================
+ Hits        11117    11226    +109     
+ Misses       3803     3719     -84
Impacted Files Coverage Δ
src/transformers/__init__.py 98.8% <100%> (+0.01%) ⬆️
src/transformers/modeling_tf_xlm_roberta.py 100% <100%> (ø)
src/transformers/data/processors/squad.py 56.72% <0%> (+27.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d87eaf...bb1aa06. Read the comment docs.

@houdaM97
Copy link

does it work even if xlm-roberta-large is pretrained pytorch model? i mean do we need to convert pytorch model to tensorflow?

@LysandreJik
Copy link
Member

@jplu I took the liberty of updating the documentation to the new format directly on your fork. Thank you for your contribution, this is awesome!

@LysandreJik LysandreJik merged commit b5625f1 into huggingface:master Jan 29, 2020
@jplu jplu deleted the tf2-xlm-roberta branch January 30, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants