Fix SpeechT5 doctests
#24483
Closed
Fix SpeechT5 doctests
#24483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Yes, that would be a better fix I agree. |
|
Thanks, I will follow the same fix in #24486 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #24434 changes
np.random.uniform(0, 1)totorch.rand([]). In the forward method ofSpeechT5ForSpeechToSpeechandSpeechT5ForTextToSpeech, the linedropout_probability = torch.rand([])is executed no matter if we are in training/inference mode. So the new change in #24434 will change the random sequences even we set a seed in the beginning ofgenerate, and we get different outputs now.Hence this PR updates the expected values for doctest.
However, I believe we should only call
dropout_probability = torch.rand([])under the condition of being in training mode.WDYT?