Check auto mappings could be imported via from transformers
#24400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Jun 21, 2023
| @@ -1028,6 +1028,7 @@ | |||
| _import_structure["models.auto"].extend( | |||
| [ | |||
| "MODEL_FOR_AUDIO_CLASSIFICATION_MAPPING", | |||
| "MODEL_FOR_AUDIO_FRAME_CLASSIFICATION_MAPPING", | |||
There was a problem hiding this comment.
this shows the new check does its job!
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As shown in #24364, we easily forget to add model mappings like
TF_MODEL_FOR_AUDIO_CLASSIFICATION_MAPPINGto some__init__files.Let's add a check to avoid and could detect such issues as early as possible.
Along this new check, also add some missing mappings to
__init__files.