Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tokenizer doc] Clarification about add_prefix_space #24368

Merged
merged 4 commits into from
Jun 20, 2023
Merged

[Tokenizer doc] Clarification about add_prefix_space #24368

merged 4 commits into from
Jun 20, 2023

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Adresses #17391, updates the documentation that suggested to use add_prefix_space when calling the tokenizer

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 20, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@antonioalegria
Copy link

antonioalegria commented Jun 20, 2023 •
edited
Loading

This blog post on constrained decoding also uses add_prefix_space in __call__ https://huggingface.co/blog/constrained-beam-search

@ArthurZucker
Copy link
Collaborator Author

The blog is not hosted on transformers but on blog, will open a PR for that too later on, thanks for the catch 😉

@ArthurZucker ArthurZucker marked this pull request as ready for review June 20, 2023 12:02
@ArthurZucker ArthurZucker requested a review from amyeroberts June 20, 2023 12:02
amyeroberts
amyeroberts approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@ArthurZucker @amyeroberts
Apply suggestions from code review
ddd48ad 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@ArthurZucker ArthurZucker merged commit 7feba74 into huggingface:main Jun 20, 2023
@ArthurZucker ArthurZucker deleted the doc-nits branch June 20, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArthurZucker @HuggingFaceDocBuilderDev @antonioalegria @amyeroberts