Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make can_generate as class method #24299

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Make can_generate as class method #24299

merged 1 commit into from
Jun 15, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 15, 2023 •
edited
Loading

What does this PR do?

Make can_generate as class method, so we can check a model (class) can generate or not without loading/creating a model instance.

(The goal of this PR is not to address the issue regarding how to check is_encoder, is_decoder etc. discussed offline).

@ydshieh ydshieh requested review from amyeroberts and gante June 15, 2023 12:07
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

amyeroberts
amyeroberts approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

gante
gante approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving it, @ydshieh 🙏

@ydshieh ydshieh merged commit 6134b9b into main Jun 15, 2023
@ydshieh ydshieh deleted the can_gen_as_class branch June 15, 2023 16:31
@ydshieh ydshieh mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gante gante gante approved these changes

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ydshieh @HuggingFaceDocBuilderDev @gante @amyeroberts