Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check of core deps #24277

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Update check of core deps #24277

merged 1 commit into from
Jun 14, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jun 14, 2023

What does this PR do?

This PR updates the check of core dependencies to:

  • include all of them (huggingface_hub and safetensors were not tested)
  • add Accelerate since we have a lot of issues with versions mismatch, with the work done on the Trainer

cc @ydshieh one of the lines removed here concerns the Python 3.6 but you should include the equivalent for your PR to drop Python 3.7

@sgugger sgugger requested a review from LysandreJik June 14, 2023 13:33
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgugger sgugger merged commit 8978b69 into main Jun 14, 2023
@sgugger sgugger deleted the update_core_dep branch June 14, 2023 14:06
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants