Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLaMa beam search when using parallelize #24224

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

FeiWang96
Copy link
Contributor

What does this PR do?

This PR fixes a crash when running beam search on LLaMa on multiple GPUs. Similar issue is also observed and fixed on T5 #11717

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 13, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts
Copy link
Collaborator

@FeiWang96 The quality checks are currently failing. To resolve these, run make style at the top level of the repo and commit any changes made.

@FeiWang96
Copy link
Contributor Author

Hi @amyeroberts , thank you for approving. I've fixed the code format issue. However, the ci failed on other tests due to some network issues. I don't have the permission to rerun.

@amyeroberts
Copy link
Collaborator

@FeiWang96 Re-ran and all passing now. Thanks again!

@amyeroberts amyeroberts merged commit 33196b4 into huggingface:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants