Correctly build models and import call_context for older TF versions #24138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
amyeroberts
approved these changes
Jun 9, 2023
|
@amyeroberts The code is in a conditional block that checks TF versions. I'm currently testing all TF versions since 2.4 to make sure this works for all of them - give me a few minutes to finish that before we merge the PR! |
|
Version testing looks good! |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Merging this now and will begin discussions about a patch release |
3 tasks
sgugger
pushed a commit
that referenced
this pull request
Jun 9, 2023
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our import for
call_contextwas wrong for older TF versions - this unfortunately makes it quite hard to load models on older TF versions! This PR fixes it, and sorry about the issue!Fixes #24133