Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlining 'checkpointing_steps' parsing #18755

Merged
merged 1 commit into from
Aug 25, 2022
Merged

streamlining 'checkpointing_steps' parsing #18755

merged 1 commit into from
Aug 25, 2022

Conversation

rahular
Copy link
Contributor

@rahular rahular commented Aug 24, 2022

What does this PR do?

As discussed in #18720, changing the checkpointing_steps parsing logic in all PyTorch examples with no trainers.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@muellerzr

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 24, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks!

@muellerzr muellerzr merged commit e944244 into huggingface:main Aug 25, 2022
@rahular rahular deleted the no_trainer_checkpointing_param_fix branch August 25, 2022 15:37
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@rahular @oneraghavan
streamlining 'checkpointing_steps' parsing (huggingface#18755)
6c65b23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahular @HuggingFaceDocBuilderDev @muellerzr