-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LayoutLMv3] Add TensorFlow implementation #18678
Conversation
… into add_tf_layoutlmv3
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com>
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
… into add_tf_layoutlmv3
@gante I followed your instructions on how to rebase, but I am afraid that it messed things up a bit. There are now 45 files changed in this PR - most of which this PR haven't even touched upon. I resolved all conflicts while rebasing by consistently accepting the incoming changes. The tests still pass. I think the problems with rebasing must be because I merged upstream/main into this PR prior to the first rebase. Sorry about the rebasing issues. I am not sure what the right course of action is now? |
@ChrisFugl can you try the solutions from this StackOverflow page? The commits will be squashed at merge time, so everything will be fine as long as the diff we see here is correct :) |
@gante Ah that was simple :) Thanks! Should be all good now. |
@ChrisFugl Fantastic, I'll merge the PR now! 🧡 Thank you so much for participating through the whole process, even with all the hiccups. LayoutLMv3 is a very useful model, I'm confident TF users will deeply appreciate your contribution 🤗 There are two post-merge action points. As always, a helping hand is appreciated (but we will do them otherwise):
|
Thank you @gante - and for your help with getting the PR merged in 😁 Super nice to get it merged in. I can give a shot at the tokenizer problem 👌 Happy to help with sharing as well. Already shared the LinkedIn post. We will probably also do some more spreading of the news in my team :) |
Co-authored-by: Esben Toke Christensen <esben.christensen@visma.com> Co-authored-by: Lasse Reedtz <lasse.reedtz@visma.com> Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> Co-authored-by: Joao Gante <joaofranciscocardosogante@gmail.com>
Adds a TensorFlow implementation of LayoutLMv3.
We have TensorFlow weights available that we have tested are able to produce the same results as the PyTorch models at microsoft/layoutlmv3-base and microsoft/layoutlmv3-large. Can you help us upload the TF weights to those locations?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
@LysandreJik @NielsRogge