Update notification service #17921
Merged
Update notification service #17921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
To make this PR visible again, @LysandreJik . More context: this is mainly for past CI - the summary table(s) could be very long as there are many more test failures. Update: I will try to save a complete table as an artifacts, so we have it. |
ydshieh
force-pushed
the
update_notification_service
branch
from
b66277b to
c070219
Compare
|
PR ready again for review. |
LysandreJik
approved these changes
Jul 21, 2022
utils/notification_service.py
Outdated
Comment on lines
330
to
333
| with open( | ||
| os.path.join(os.getcwd(), "test_failure_tables/model_failures_report.txt"), "w", encoding="UTF-8" | ||
| ) as fp: | ||
| fp.write(model_failures_report) |
There was a problem hiding this comment.
Could this be reformatted? It's a bit hard to read right now :)
There was a problem hiding this comment.
Changed to :-)
transformers/utils/notification_service.py
Lines 324 to 326 in 5d3026f
|
Perfect! |
muellerzr
pushed a commit
that referenced
this pull request
Jul 25, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Let me run a dummy test before mergeA dummy run with very long blocks
https://github.com/huggingface/transformers/runs/7094507618?check_suite_focus=true