Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation/training: italian translation training.mdx #17662

Merged
merged 12 commits into from
Jul 18, 2022
Merged

Translation/training: italian translation training.mdx #17662

merged 12 commits into from
Jul 18, 2022

Conversation

nickprock
Copy link
Contributor

@nickprock nickprock commented Jun 10, 2022

What does this PR do?

  • added translation.mdx
  • updated _toctree.yml

See issue: #17459

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@omarespejel @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 10, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger requested a review from omarespejel June 10, 2022 17:54
@mfumanelli
Copy link
Contributor

Hi @nickprock , I found these typos could you edit the file? Thanks!

  • "benifici" --> "benefici"
  • "stratergia" --> "strategia"
  • "Addestranento" --> "Addestramento"
  • "Le [Trainer] API supporta" --> "L'API [Trainer] supporta"
  • Here: "tutti gli iperparametri che puoi impostare" It doesn't seem so clear, I would maybe put it this way: "tutti gli iperparametri che si possono calibrare". What do you think?
  • "nonchè" --> "nonché"
  • "funzione accuratezza" maybe I would keep the function names in English (i.e., with the original name)
  • "maggiorni informazioni" --> "maggiori informazioni"
  • "le Keras API" --> "l'API di Keras"
  • "Sii sicuro" --> "Assicurati" (for gender neutrality)
  • "sepecificare" --> "specificare"
  • "Compila e fit" --> "Compilazione e adattamento"
  • "Per gli utenti che preferiscono scrivere il loro personale ciclo di addestramento" --> "Per chi preferisse scrivere un proprio ciclo di addestramento personale"
  • "pò di memoria" --> "po' di memoria"
  • "perchè" --> "perché"
  • "adesso sei pronto per addestrare!" --> "adesso possiamo addestrare!" (for gender neutrality)

@nickprock
Copy link
Contributor Author

Thanks for the review @mfumanelli 🙏, I fixed them.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@nickprock
Copy link
Contributor Author

I fixed and I'm waiting the review

@sgugger
Copy link
Collaborator

sgugger commented Jul 18, 2022

cc @omarespejel

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same story as in #17600
Thanks a lot!

@sgugger sgugger merged commit 8e445ca into huggingface:main Jul 18, 2022
viclzhu pushed a commit to viclzhu/transformers that referenced this pull request Jul 20, 2022
…7662)

* added training.mdx

* updated training.mdx

* updated training.mdx

* updated training.mdx

* updated _toctree.yml

* fixed typos after review

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants