-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make classifier backbone dynamic maskformer, mask2former #24244
Labels
Feature request
Request for a new feature
Comments
Thank you for solving this issue. But there is still problem.
The supported backbones variable hinders to allow any backbones other than
swin.
Please check this line. I had to write child class and had to modify this
line to solve this problem.
https://github.com/huggingface/transformers/blob/main/src/transformers/models/mask2former/configuration_mask2former.py#L124
…On Tue, 27 Jun 2023, 11:34 pm Sylvain Gugger, ***@***.***> wrote:
Closed #24244 <#24244>
as completed via #24259
<#24259>.
—
Reply to this email directly, view it on GitHub
<#24244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQSQGCPK433TDSJZKGBL7VDXNMKRDANCNFSM6AAAAAAZEYRWOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
cc @amyeroberts |
5 tasks
Hi @tanzzilaalam, you're completely right. I've opened a PR - #24532 - which should resolve this and allow you to pass in any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
Make classifier backbone dynamic maskformer, mask2former. Currently it only supports swin transformer.
link example: https://github.com/huggingface/transformers/blob/main/src/transformers/models/mask2former/modeling_mask2former.py#L1393
Motivation
If this feature request successful, it will help to benchmark for new clasifier easily.
The text was updated successfully, but these errors were encountered: