-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyo3: update to 0.17 #1066
pyo3: update to 0.17 #1066
Conversation
@@ -2,7 +2,7 @@ | |||
name = "tokenizers-python" | |||
version = "0.11.0" | |||
authors = ["Anthony MOI <m.anthony.moi@gmail.com>"] | |||
edition = "2018" | |||
edition = "2021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Thanks to your work I was able to make it work (by removing the Thanks a ton for this work, and I'm all up for upgrading to |
@Narsil I've since released PyO3 0.17.2 and this branch now builds for me locally, should be good for review and also it would be great to have the CI run approved to confirm it passes your CI. |
The documentation is not available anymore as the PR was closed or merged. |
Hey @davidhewitt Thanks for the work. I took the liberty of rebasing (to prevent merge issues) and modifying the makefile line that was failing ! |
Still a WIP; doing this I found an unintended API change in PyO3 which I think I can push a patch release for.