Skip to content

Commit

Permalink
Upgrade pyo3 to 0.16 (#956)
Browse files Browse the repository at this point in the history
* Upgrade pyo3 to 0.15

Rebase-conflicts-fixed-by: H. Vetinari <h.vetinari@gmx.com>

* Upgrade pyo3 to 0.16

Rebase-conflicts-fixed-by: H. Vetinari <h.vetinari@gmx.com>

* Install Python before running cargo clippy

* Fix clippy warnings

* Use `PyArray_Check` instead of downcasting to `PyArray1<u8>`

* Enable `auto-initialize` of pyo3 to fix `cargo test
--no-default-features`

* Fix some test cases

Why do they change?

* Refactor and add SAFETY comments to `PyArrayUnicode`

Replace deprecated `PyUnicode_FromUnicode` with `PyUnicode_FromKindAndData`

Co-authored-by: messense <messense@icloud.com>
  • Loading branch information
h-vetinari and messense committed May 5, 2022
1 parent 6533bf0 commit 519cc13
Show file tree
Hide file tree
Showing 19 changed files with 614 additions and 614 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ jobs:
toolchain: stable
components: rustfmt, clippy

- name: Install Python
uses: actions/setup-python@v2
with:
python-version: 3.9
architecture: "x64"


- name: Cache Cargo Registry
uses: actions/cache@v1
with:
Expand All @@ -88,12 +95,6 @@ jobs:
command: clippy
args: --manifest-path ./bindings/python/Cargo.toml --all-targets --all-features -- -D warnings

- name: Install Python
uses: actions/setup-python@v2
with:
python-version: 3.9
architecture: "x64"

- name: Install
working-directory: ./bindings/python
run: |
Expand Down
1 change: 0 additions & 1 deletion bindings/python/.cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ rustflags = [
"-C", "link-arg=dynamic_lookup",
"-C", "link-arg=-mmacosx-version-min=10.11",
]

Loading

0 comments on commit 519cc13

Please sign in to comment.