Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unroll notify error into generate response #2597

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

drbh
Copy link
Collaborator

@drbh drbh commented Oct 1, 2024

This PR unrolls the message from notify_error in order to give the model a way to not choose a tool and respond with a non constrained generation

Narsil
Narsil previously approved these changes Oct 1, 2024
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@drbh drbh merged commit d22b0c1 into main Oct 2, 2024
12 of 13 checks passed
@drbh drbh deleted the unroll-notify-error-into-response branch October 2, 2024 15:35
drbh added a commit that referenced this pull request Oct 3, 2024
drbh added a commit that referenced this pull request Oct 3, 2024
Revert "Unroll notify error into generate response (#2597)"

This reverts commit d22b0c1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants