Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ratatui not (deprecated) tui #2521

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

strickvl
Copy link
Contributor

Noticed that TGI uses the archived tui-rs crate so I followed their migration guide to do a full switch over to ratatui.

It's intended as a drop-in replacement, but when rebuilding after updating the dependencies I noted a couple of suggestions to update some code following deprecations. So I made those changes. The rest are just formatting / alphabetical order changes as a result of the name change.

I bumped it to the latest version of both crossterm and ratatui (as it seems they have to be in sync).

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot this looks great !

@Narsil Narsil merged commit 9cca3e0 into huggingface:main Sep 13, 2024
Narsil pushed a commit that referenced this pull request Sep 14, 2024
* use ratatui not archived tui

* bump ratatui all the way with options
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
* use ratatui not archived tui

* bump ratatui all the way with options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants