Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODEL_ID propagation fix #2290

Closed
wants to merge 1 commit into from
Closed

MODEL_ID propagation fix #2290

wants to merge 1 commit into from

Conversation

seungrokj
Copy link

Hi,

This is to fix the bug here:
File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/flash_causal_lm.py", line 1160, in warmup
f"tunableop_{MODEL_ID.replace('/', '-')}_tp{self.world_size}_rank{self.rank}.csv",

MODEL_ID is not properly propaged.

Please review this @OlivierDehaene @Narsil

Regards,
Seungrok

@ErikKaum
Copy link
Member

Hi @seungrokj 👋

Thanks for the PR 👍 This seems correct.
Could you also share how to reproduce the original bug so that I can double check on my machine?

@ErikKaum ErikKaum self-assigned this Jul 26, 2024
@seungrokj
Copy link
Author

Hi @ErikKaum

Nice to meet you!

To reproduce it, in AMD machine (MI300 or MI250/MI210)

export model=NousResearch/Meta-Llama-3-8B
export volume=$PWD/data
docker run --device /dev/kfd --device /dev/dri --shm-size 1g -p 8080:80 -v $volume:/data ghcr.io/huggingface/text-generation-inference:latest-rocm --mo
del-id $model --num-shard 1

Then it will just generate error here:
File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/flash_causal_lm.py", line 1160, in warmup
f"tunableop_{MODEL_ID.replace('/', '-')}_tp{self.world_size}_rank{self.rank}.csv",

@ErikKaum
Copy link
Member

Sorry for the slow reply @seungrokj
change will be merged in with this one: #2329

@ErikKaum
Copy link
Member

I'll close this one as the it's in with #2329 👍

@ErikKaum ErikKaum closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants