Softcapping for gemma2. #2273
Merged
Softcapping for gemma2. #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
previously approved these changes
Jul 22, 2024
| @@ -925,7 +925,11 @@ def __init__( | |||
| assert self.num_kv_heads > 0 | |||
|
|
|||
| if head_size is None: | |||
| self.head_size = config.hidden_size // config.num_attention_heads | |||
| if getattr(config, "head_dim", None): | |||
| # hidden_size / num_attention_heads is wrong in `google/gemma-2-9b-it` | |||
There was a problem hiding this comment.
We can pass the head dim to FlashCausalLM, similar to deepseek v2:
Avoids cluttering this constructor with too much model-specific stuff.
There was a problem hiding this comment.
Fixed, you are correct (I'm still quite confused about those numbers in the config tho, I think it's because of how they fused qkv.).
danieldk
previously approved these changes
Jul 22, 2024
ErikKaum
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Softcapping for gemma2. * Less clutter. * No access to transformers config, only config_dict here. * 0.0 is the null value in the C++ API.
ErikKaum
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Softcapping for gemma2. * Less clutter. * No access to transformers config, only config_dict here. * 0.0 is the null value in the C++ API.
4 tasks
yuanwu2017
pushed a commit
to yuanwu2017/tgi-gaudi
that referenced
this pull request
Sep 26, 2024
* Softcapping for gemma2. * Less clutter. * No access to transformers config, only config_dict here. * 0.0 is the null value in the C++ API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.