Better error messages on outdated context manager. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
force-pushed
the
better_implem_of_drop
branch
from
9005fe1 to
fced0a0
Compare
|
The documentation is not available anymore as the PR was closed or merged. |
McPatate
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR might improve what was done in PR : #166
Link to idea: PyO3/pyo3#1205 (comment)
The problem is showcased in the test, were usage of
fafter the context manager would create a recursion error instead of a simple error.By encapsulating everything within an
innerclass, we case rely on the type system to provide a correct error which is that the context manager is outdated.