[BT] Added BT for Speech2Text model #969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @younesbelkada , I just opened this PR from a draft PR. Could you take a look when you have the time, please? I left some comments on the description above for reference. Thank you! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #488 (issue)
Before submitting
Description
@younesbelkada
I've followed your suggestion from the documentation here and your suggestion here for the Tapas model. I see that the speech2text encoder layer module was copied from MBart. I'm opening a draft PR as I'm not sure if I missed anything completely and also wasn't sure about the testing for this model.
Please let me know if any fixes are needed, thank you!