Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timm Models integration to Optimum-intel #404

Merged
merged 19 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion optimum/intel/openvino/modeling.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import logging
import os
from pathlib import Path
from typing import Optional, Union

import numpy as np
import openvino
import torch
import transformers
from huggingface_hub import model_info
from transformers import (
AutoConfig,
AutoModel,
Expand All @@ -31,6 +33,7 @@
AutoModelForQuestionAnswering,
AutoModelForSequenceClassification,
AutoModelForTokenClassification,
PretrainedConfig,
)
from transformers.file_utils import add_start_docstrings, add_start_docstrings_to_model_forward
from transformers.modeling_outputs import (
Expand All @@ -47,6 +50,7 @@
from optimum.exporters import TasksManager

from .modeling_base import OVBaseModel
from .modeling_timm import TimmConfig, TimmForImageClassification, TimmOnnxConfig


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -497,6 +501,49 @@ class OVModelForImageClassification(OVModel):
def __init__(self, model=None, config=None, **kwargs):
super().__init__(model, config, **kwargs)

@classmethod
def from_pretrained(
cls,
model_id: Union[str, Path],
export: bool = False,
config: Optional["PretrainedConfig"] = None,
use_auth_token: Optional[Union[bool, str]] = None,
revision: Optional[str] = None,
force_download: bool = False,
cache_dir: Optional[str] = None,
subfolder: str = "",
local_files_only: bool = False,
task: Optional[str] = None,
trust_remote_code: bool = False,
**kwargs,
):
# Fix the mismatch between timm_config and huggingface_config
if not os.path.isdir(model_id) and model_info(model_id).library_name == "timm":
config = TimmConfig.from_pretrained(model_id, **kwargs)
model = TimmForImageClassification.from_pretrained(model_id, **kwargs)
onnx_config = TimmOnnxConfig(model.config)

return cls._to_onnx_to_load(
model=model,
config=config,
onnx_config=onnx_config,
)
else:
return super().from_pretrained(
model_id=model_id,
config=config,
export=export,
use_auth_token=use_auth_token,
revision=revision,
force_download=force_download,
cache_dir=cache_dir,
subfolder=subfolder,
local_files_only=local_files_only,
task=task,
trust_remote_code=trust_remote_code,
**kwargs,
)

@add_start_docstrings_to_model_forward(
IMAGE_INPUTS_DOCSTRING.format("batch_size, num_channels, height, width")
+ IMAGE_CLASSIFICATION_EXAMPLE.format(
Expand Down
27 changes: 26 additions & 1 deletion optimum/intel/openvino/modeling_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from transformers import PretrainedConfig
from transformers.file_utils import add_start_docstrings

from optimum.exporters.onnx import export
from optimum.exporters.onnx import OnnxConfig, export
from optimum.exporters.tasks import TasksManager
from optimum.modeling_base import OptimizedModel

Expand Down Expand Up @@ -276,6 +276,31 @@ def _from_transformers(
)

onnx_config = onnx_config_class(model.config)

return cls._to_onnx_to_load(
model=model,
config=config,
onnx_config=onnx_config,
use_auth_token=use_auth_token,
revision=revision,
force_download=force_download,
cache_dir=cache_dir,
local_files_only=local_files_only,
)

@classmethod
def _to_onnx_to_load(
cls,
model: PreTrainedModel,
config: PretrainedConfig,
onnx_config: OnnxConfig,
use_auth_token: Optional[Union[bool, str]] = None,
revision: Optional[str] = None,
force_download: bool = False,
cache_dir: Optional[str] = None,
local_files_only: bool = False,
**kwargs,
):
save_dir = TemporaryDirectory()
save_dir_path = Path(save_dir.name)

Expand Down
5 changes: 1 addition & 4 deletions optimum/intel/openvino/modeling_diffusion.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,6 @@ def _from_pretrained(
cls.config_name,
}
)
ignore_patterns = ["*.msgpack", "*.safetensors", "*pytorch_model.bin"]
if not from_onnx:
ignore_patterns.extend(["*.onnx", "*.onnx_data"])
fxmarty marked this conversation as resolved.
Show resolved Hide resolved
# Downloads all repo's files matching the allowed patterns
model_id = snapshot_download(
model_id,
Expand All @@ -228,7 +225,7 @@ def _from_pretrained(
use_auth_token=use_auth_token,
revision=revision,
allow_patterns=allow_patterns,
ignore_patterns=ignore_patterns,
ignore_patterns=["*.msgpack", "*.safetensors", "*pytorch_model.bin"],
)
new_model_save_dir = Path(model_id)

Expand Down
Loading