-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💫 Incompatibilities & support on later versions of spaCy #197
Comments
Yes, the plan with @honnibal and @ines is to help @thomwolf maintain this awesome spaCy extension and to make sure it can stay in-sync when there are new releases for spaCy. No timeline yet, but stay tuned ;-) For now, you can work with neuralcoref and spaCy>2.1 if you first install your required version of spaCy, and then build neuralcoref from source. If that doesn't work, you can also try compiling spaCy from source first (in a clean environment), then compile neuralcoref from source. If you are running into incompatibility issues and prefer not to build from source, the other option is to downgrade spaCy to 2.1.0, which is compatible with neuralcoref 4.0. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I believe this is still an issue. Is there another workaround that does not require building from source? Also, I don't want the bot to close this without a fix. |
No, there's no other workaround for the moment, and yes this issue will be addressed - which is why I removed the wontfix label ;-) |
For some reason I was having trouble building I've attached my reproducible example getting it working with the latest version of spaCy. Any tips on doing this better / more easily? all:
python3 -m venv .venv
.venv/bin/pip install cython boto3
git clone https://github.com/explosion/spaCy.git || true
.venv/bin/pip install -r spaCy/requirements.txt
.venv/bin/python spaCy/setup.py build_ext --inplace
cp -R spaCy/spacy .venv/lib/python3.8/site-packages/
git clone https://github.com/huggingface/neuralcoref.git || true
.venv/bin/python neuralcoref/setup.py build_ext --inplace
cp -R neuralcoref/neuralcoref .venv/lib/python3.8/site-packages/
.venv/bin/python -m spacy download en
test:
.venv/bin/python -c "import spacy; nlp = spacy.load('en'); import neuralcoref; neuralcoref.add_to_pipe(nlp); doc = nlp(u'My sister has a dog. She loves him.'); print(doc._.coref_clusters)"
clean:
rm -rf .venv spacy neuralcoref I really wish I could do something like:
but that wasn't working for me. |
The way I do it, after pulling both from github and creating a new
|
ahh, I didn't realize you're suppose to |
We're currently working hard on getting spaCy v.3 out, which will use the revamped thinc. Once all that is done, the next priority will be to get |
To fix neuralcoref compatability problems (see huggingface/neuralcoref#197)
I did this with
and then
|
just a quick fyi: I personally still got the |
Hi, it seems to work fine with spaCy 2.3.0 without building spaCy from source.
But I had to change the requirements.txt to make it work, because here it says Could you please update the requirements.txt I'd like to use neuralcoref in a book and therefore easy setup would be great! |
The approach that works for us in a CI setting is installing Example Makefile:
Note if you have it part of larger NLP stack, you can also add |
The requirements are now updated. There was a bug in spaCy 2.2 which meant that the pip-installed version of spaCy did not distribute the Thanks for the confirmation! |
I just got a segfault when trying to use neuralcoref with spacy 2.3.2 and had to downgrade to spacy 2.1.3 for it to work, even though the requirements file allows spacy>=2.1.0,<3.0.0. |
Hm, that's odd. Did you build neuralcoref from source after installing spaCy 2.3.2 ? |
I installed neuralcoref via pip after installing spaCy 2.3.2. |
Yea, that explains the segfault. You'll need to build neuralcoref from source if you want to use spacy > 2.1. |
thanks for the great tool. though, im wondering, is neuralcoref actually under active development or what's the overall status? for example, this issue is almost 2 years old. further, in the dev branch the latest commit is 2 months old (and it's only regarding some typos). also, spacy 3.0 has been out for a while and still there's no support. |
Hi @fhamborg! Since my original post in September 2019, quite a bit has changed. We initially intended to bring this code base up-to-date with the latest spaCy, but then we ended up revamping the internals of spaCy quite a bit for its 3.0 release. Long story short, at Explosion we're working on a built-in coreference module that will be part of the core spaCy library. You can follow its development here: explosion/spaCy#7264. You'll see that we've been actively working on this. Most of the code is written, but it needs some more debugging and fine-tuning. I can't speak for HuggingFace and what they intend to do with |
That's great to hear, thank you a lot for the update :) |
To fix neuralcoref compatability problems (see huggingface/neuralcoref#197)
Is there any plan/ date to get neuralcoref to work on the latest version of spaCy (ver 2.1.8)? Thanks
The text was updated successfully, but these errors were encountered: