Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add license header to src files #89

Merged
merged 8 commits into from
Mar 6, 2024
Merged

add license header to src files #89

merged 8 commits into from
Mar 6, 2024

Conversation

NathanHB
Copy link
Member

@NathanHB NathanHB commented Mar 4, 2024

No description provided.

@NathanHB NathanHB requested a review from clefourrier March 4, 2024 13:44
@NathanHB
Copy link
Member Author

NathanHB commented Mar 4, 2024

Oh thanks for the review, forgot about the code we used from other sources 😅

clefourrier
clefourrier approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you first need to change all the licenses for imported snippets from libs, and check what's happening with the code style

@NathanHB
Copy link
Member Author

NathanHB commented Mar 4, 2024

Code style is because of the preview = true flag, it raised new issues in the code.

@clefourrier
Copy link
Member

Maybe you need to update the pre-commit hook?

@NathanHB NathanHB linked an issue Mar 4, 2024 that may be closed by this pull request
Add the license to all files headers #87
Closed
@NathanHB NathanHB merged commit 2d529ac into main Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clefourrier clefourrier clefourrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the license to all files headers
2 participants
@NathanHB @clefourrier