Update huggingface-hub for compatibility with datasets 2.18 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
changed the title
NathanHB
reviewed
Mar 4, 2024
NathanHB
approved these changes
Mar 4, 2024
|
Edit: just talked with @albertvillanova , and if we bump |
|
0.21.2 or larger (latest is 0.21.3). |
albertvillanova
changed the title
lhoestq
reviewed
Mar 4, 2024
| @@ -237,6 +237,7 @@ Summary: create a **line summary** of your evaluation, in `src/lighteval/tasks/t | |||
| - `metric` (list), the metrics you want to use for your evaluation (see next section for a detailed explanation) | |||
| - `output_regex` (str), A regex string that will be used to filter your generation. (Genrative metrics will only select tokens that are between the first and the second sequence matched by the regex. For example, for a regex matching `\n` and a generation `\nModel generation output\nSome other text` the metric will only be fed with `Model generation output`) | |||
| - `frozen` (bool), for now is set to False, but we will steadily pass all stable tasks to True. | |||
| - `trust_dataset` (bool), set to True if you trust the dataset. | |||
There was a problem hiding this comment.
(nit) why not call it "trust_remote_code" as the parameter name in datasets ?
There was a problem hiding this comment.
To not confuse it with trust_remote_code required in models, initially ^^
There was a problem hiding this comment.
I'm OK with adding it, feel free to open an issue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.