Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored reuse_existing in config file #431

Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Dec 10, 2024

Fix ignored reuse_existing field in config file.

Currently, there is a reuse_existing field in all example config files for evaluation in inference endpoints. See for example:

reuse_existing: false # if true, ignore all params in instance, and don't delete the endpoint after evaluation

or
reuse_existing: false # if true, ignore all params in instance, and don't delete the endpoint after evaluation

However, this field is ignored when parsing the config file because should_reuse_existing is parsed instead:

"should_reuse_existing": config["base_params"].get("should_reuse_existing"),

This PR fixes this issue by renaming should_reuse_existing to reuse_existing, so that it is aligned with the InferenceEndpointModel parameter name.

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova albertvillanova merged commit f2e1f69 into huggingface:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants