-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the programmatic interface using an already in memory loaded model #390
Conversation
Ideally, we would want to migrate a bunch of params from the ModelParams to the PipelineParams:
Would simplify model config code. Wdyt @NathanHB ? (Should probably be another PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and looks great !!
Cool! Waiting for some last feedback from Lewis and will merge afterwards |
#390) --------- Co-authored-by: Nathan Habib <30601243+NathanHB@users.noreply.github.com>
To test the PR