Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a TypeError in Sacrebleu. #387

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Fixes a TypeError in Sacrebleu. #387

merged 7 commits into from
Nov 18, 2024

Conversation

JoelNiklaus
Copy link
Contributor

SacreBleu expects the hypotheses to be a list of strings. We gave a list of list of strings which leads to a TypeError. I flattened the list to fix this.

@clefourrier
Copy link
Member

You'll need to run the ruff styling :)

@clefourrier
Copy link
Member

Hi! I edited the readme to make the styling steps clearer, you'll need to run

pip install -e .[dev]
pre-commit install
pre-commit run --all-files

@clefourrier clefourrier merged commit 9b43560 into huggingface:main Nov 18, 2024
2 checks passed
hynky1999 pushed a commit that referenced this pull request Nov 29, 2024
@JoelNiklaus @clefourrier
Fixes a TypeError in Sacrebleu. (#387)
6af5280 
---------

Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
@JoelNiklaus JoelNiklaus deleted the fix_sacre_bleu_problem branch December 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clefourrier clefourrier clefourrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelNiklaus @clefourrier