Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a TypeError for generative metrics. #386

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

JoelNiklaus
Copy link
Contributor

Fixes the following error for metrics like ter, chrf or bleu.

TypeError: GenerativePreparator.prepare() got multiple values for argument 'golds'.

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@clefourrier clefourrier merged commit 9be2a38 into huggingface:main Nov 13, 2024
2 checks passed
hynky1999 pushed a commit that referenced this pull request Nov 29, 2024
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
@JoelNiklaus JoelNiklaus deleted the fix_metric_error branch December 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants