Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GGUF quantization types #729

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Update GGUF quantization types #729

merged 1 commit into from
Jun 3, 2024

Conversation

CISC
Copy link
Contributor

@CISC CISC commented Jun 1, 2024 •
edited
Loading

mishig25
mishig25 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! Thanks so much for the contribution. I think if you want, you can even document BF16 in the ggml format docs https://github.com/ggerganov/ggml/blob/master/docs/gguf.md?plain=1#L146-L151 😊

@mishig25 mishig25 merged commit d00b389 into huggingface:main Jun 3, 2024
4 checks passed
@CISC CISC deleted the update-gguf-quant-types branch June 3, 2024 08:34
julien-c
julien-c reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to regenerate the table in https://huggingface.co/docs/hub/gguf?

@mishig25 mishig25 mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c left review comments

@mishig25 mishig25 mishig25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CISC @julien-c @mishig25