Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] pin max torch version to fix CI errors #9709

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Conversation

a-r-r-o-w
Copy link
Member

What does this PR do?

Only pinned until we figure out what's going on with torch 2.5.0

Context: https://huggingface.slack.com/archives/C065E480NN9/p1729230272869569

#9691, #9704

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@a-r-r-o-w a-r-r-o-w requested review from DN6 and sayakpaul October 18, 2024 11:28
setup.py Outdated Show resolved Hide resolved
@sayakpaul
Copy link
Member

setup.py Outdated Show resolved Hide resolved
@a-r-r-o-w
Copy link
Member Author

Seems like everything passed: https://github.com/huggingface/diffusers/actions/runs/11403577400

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IIRC you already triggered the CI, so should be good.

@a-r-r-o-w a-r-r-o-w merged commit 56d6d21 into main Oct 19, 2024
3 checks passed
@a-r-r-o-w a-r-r-o-w deleted the pin-max-torch-version branch October 19, 2024 20:21
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* pin max torch version

* update

* Update setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants