-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Official callbacks] SDXL Controlnet CFG Cutoff #9311
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LGTM. Just one concern if this issue exists in other callbacks |
yeah, this was discussed in the original PR, we probably need to do this kind of callbacks to all the different pipelines, so this means inpaint, img2img and for different model archs. But this is the only one so far that someone asked for it, so maybe lets evaluate to do them when someone asks for an official callback, also the community is open to do PRs with them. Also probably we need to start naming the args more consistently, for this pipeline the controlnet image is |
Thanks @asomoza!! |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@asomoza Hello, I'm trying SDXL with multicontrolnets, using the code in this PR leads to the same error as #8686. I've tried replace this line with |
@kunc01 you should open a new issue and provide example code |
What does this PR do?
Adds a new official callback for the SDXL Controlnet pipeline.
After testing with different alternatives, I found that just adding a new callback for this specific pipeline was the best and simpler solution.
Fixes #8686
How to test
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@rootonchair @juancopi81