Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] introduce controlnet module #8768

Merged
merged 26 commits into from
Nov 7, 2024
Merged

[Core] introduce controlnet module #8768

merged 26 commits into from
Nov 7, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

We have several ControlNet models now and I think it makes sense to now have a separate controlnets module under src/diffisers/models.

@sayakpaul sayakpaul requested a review from DN6 July 2, 2024 10:55
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul marked this pull request as ready for review July 2, 2024 11:40
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Oct 23, 2024
@sayakpaul
Copy link
Member Author

@DN6 can you give it another look please?

@sayakpaul sayakpaul requested a review from DN6 October 23, 2024 14:08
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait hold on. I'm cool to move the controlnet models into their own module.

For the pipelines I think the plan is on moving controlnet pipelines into their base pipeline folders. e.g. SD3 ControlNets go into the SD3 folder cc: @yiyixuxu @asomoza

@sayakpaul
Copy link
Member Author

sayakpaul commented Oct 31, 2024

We're not moving the pipelines in this PR. We're only moving the models i.e., classes subclassed from ModelMixin. What am I missing?

@sayakpaul sayakpaul merged commit ded3db1 into main Nov 7, 2024
18 checks passed
@sayakpaul sayakpaul deleted the controlnet-module branch November 7, 2024 02:08
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* move vae flax module.

* controlnet module.

* prepare for PR.

* revert a commit

* gracefully deprecate controlnet deps.

* fix

* fix doc path

* fix-copies

* fix path

* style

* style

* conflicts

* fix

* fix-copies

* sparsectrl.

* updates

* fix

* updates

* updates

* updates

* fix

---------

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants