-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] remove deprecation from transformer2d regarding the output class. #8698
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just deprecate it when it is actually used (not when it is imported)
also can we do a search and make sure to update it for entire codebase (including docs and docstrings). for example, sd3 controlnet used it and we didn't catch that
from .transformers.transformer_2d import Transformer2DModelOutput |
@yiyixuxu I think I have addressed your comments. |
oh thanks you can see that sd3 is still importing from the wrong place
|
Okay, so I thought the imports would be a bit standardized. Also weird that it didn't show up on VSCode. I think that is what has led to confusion in the past, too. I will do a code search on GitHub itself, as you did. Seems like it's more robust. |
Hopefully, this one should cut it 🤞 |
…ass. (#8698) * remove deprecation from transformer2d regarding the output class. * up * deprecate more
…ass. (#8698) * remove deprecation from transformer2d regarding the output class. * up * deprecate more
What does this PR do?
Follow https://huggingface.slack.com/archives/C03HBN1C8CW/p1719318647536649.
@LysandreJik @julien-c just FYI.