Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] remove deprecation from transformer2d regarding the output class. #8698

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul requested a review from yiyixuxu June 25, 2024 14:56
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just deprecate it when it is actually used (not when it is imported)

also can we do a search and make sure to update it for entire codebase (including docs and docstrings). for example, sd3 controlnet used it and we didn't catch that

from .transformers.transformer_2d import Transformer2DModelOutput

@sayakpaul sayakpaul requested a review from yiyixuxu June 26, 2024 01:53
@sayakpaul
Copy link
Member Author

@yiyixuxu I think I have addressed your comments.

@yiyixuxu
Copy link
Collaborator

oh thanks
can we do a search, manually look through all the results, and make sure to update everywhere (including the doc strings) https://github.com/search?q=repo%3Ahuggingface%2Fdiffusers%20Transformer2DModelOutput&type=code

you can see that sd3 is still importing from the wrong place

from .transformer_2d import Transformer2DModelOutput

@sayakpaul
Copy link
Member Author

Okay, so I thought the imports would be a bit standardized. Also weird that it didn't show up on VSCode. I think that is what has led to confusion in the past, too. I will do a code search on GitHub itself, as you did. Seems like it's more robust.

@sayakpaul
Copy link
Member Author

Hopefully, this one should cut it 🤞

@yiyixuxu yiyixuxu merged commit 10b4e35 into main Jun 26, 2024
18 checks passed
@yiyixuxu yiyixuxu deleted the remove-transformeroutput-deprecation branch June 26, 2024 17:35
sayakpaul added a commit that referenced this pull request Jun 27, 2024
…ass. (#8698)

* remove deprecation from transformer2d regarding the output class.

* up

* deprecate more
sayakpaul added a commit that referenced this pull request Dec 23, 2024
…ass. (#8698)

* remove deprecation from transformer2d regarding the output class.

* up

* deprecate more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants