[Support PyTorch 1.8] Remove inference mode #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
anton-l
approved these changes
Oct 3, 2022
|
Comment: There are a few mentions of I also have a question, do we have a policy to obsolete and upgrade dependencies? We currently seem to require PyTorch >= 1.4, I'm not sure about the features that got added in later versions and could inadvertently break that assumption. But more importantly, how do we decide that we no longer support an old version of any of the dependencies? |
|
I'm okay with replacing it with |
|
Ok for me to leave it in the docs (if we mention that one needs PyTorch >= 1.9). If |
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
…ggingface#707) At this point, all the utilities of SD web and CLI are exactly same. Signed-Off-by: Gaurav Shukla <gaurav@nod-labs.com> Signed-off-by: Gaurav Shukla <gaurav@nod-labs.com>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try to not force high PyTorch versions if we can avoid it.
Inference mode was only introduced in PyTorch 1.9. The safety checker is used in many different other libraries (mainly
ComVis/stable-diffusion) and we don't want to force these libraries to use higher PyTorch versions.cc @anton-l