Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PNDM in LDM pipeline] use inspect in pipeline instead of unused kwargs #167

Merged
merged 1 commit into from
Aug 12, 2022
Merged

[PNDM in LDM pipeline] use inspect in pipeline instead of unused kwargs #167

merged 1 commit into from
Aug 12, 2022

Conversation

patil-suraj
Copy link
Contributor

This PR updates the LDMTextToImagePipeline and LDMPipeline to determine wether the scheduler.step accepts the eta arg using inspect.signature. And removes the unused kwargs from PNDMScheduler

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 12, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

patrickvonplaten
patrickvonplaten reviewed Aug 12, 2022
View reviewed changes
src/diffusers/schedulers/scheduling_pndm.py
@@ -116,7 +116,6 @@ def step(
model_output: Union[torch.FloatTensor, np.ndarray],
timestep: int,
sample: Union[torch.FloatTensor, np.ndarray],
**kwargs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

patrickvonplaten
patrickvonplaten approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@patil-suraj patil-suraj merged commit c72e343 into main Aug 12, 2022
@patil-suraj patil-suraj deleted the support-pndm-in-ldm branch August 12, 2022 14:59
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patil-suraj
[PNDM in LDM pipeline] use inspect in pipeline instead of unused kwar…
43c269d 
…gs (huggingface#167)

use inspect instead of unused kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@anton-l anton-l Awaiting requested review from anton-l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patil-suraj @HuggingFaceDocBuilderDev @patrickvonplaten