Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify add_column() to optionally accept a FeatureType as param #7143

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Modify add_column() to optionally accept a FeatureType as param #7143

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
383a18e
Modify add_column() to optionally accept a FeatureType param
Sep 8, 2024
f1c9b59
Add feature param to add_column() docstring
Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5613,7 +5613,9 @@ def push_to_hub(

@transmit_format
@fingerprint_transform(inplace=False)
def add_column(self, name: str, column: Union[list, np.array], new_fingerprint: str):
def add_column(
self, name: str, column: Union[list, np.array], new_fingerprint: str, feature: Optional[FeatureType] = None
):
"""Add column to Dataset.

<Added version="1.7"/>
Expand All @@ -5640,7 +5642,13 @@ def add_column(self, name: str, column: Union[list, np.array], new_fingerprint:
})
```
"""
column_table = InMemoryTable.from_pydict({name: column})

if feature:
pyarrow_schema = Features({name: feature}).arrow_schema
else:
pyarrow_schema = None

column_table = InMemoryTable.from_pydict({name: column}, schema=pyarrow_schema)
_check_column_names(self._data.column_names + column_table.column_names)
dataset = self.flatten_indices() if self._indices is not None else self
# Concatenate tables horizontally
Expand Down
Loading