-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #6761
Remove deprecated code #6761
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Thanks for cleaning this :) I'm also fine with renaming |
(Yep, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you. We forgot to remove all this dead code.
There are however some red CI tests to be fixed...
@albertvillanova Sorry about that, tests are now fixed! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks again.
Show benchmarksPyArrow==8.0.0 Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
|
What does this PR do?
list_files_info
in favor oflist_repo_tree
. As of0.23
,list_files_info
will be removed for good.datasets
had a utility to support both pre-0.20 and post-0.20 versions. Sincehfh
version is already pinned to>=0.21.2
, I removed the legacy part.preupload_lfs_files
had also a different behavior between<0.20
and>=0.20
. I remove it since huggingface_hub is now pinned to>=0.21.2
hf_hub_url
is overwritten to default to the dataset repo_type. I do think it is misleading to keep the same method naming for it. I renamed it toget_dataset_url
for clarity. Let me know if you prefer to see this change reverted.