Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename obsolete mentions to datasets_based #805

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Rename obsolete mentions to datasets_based #805

merged 1 commit into from
Feb 13, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 13, 2023

  • rename prefix WORKER_LOOP_ to WORKER_
  • rename DATASETS_BASED_ENDPOINT to WORKER_ENDPOINT
  • rename DATASETS_BASED_CONTENT_MAX_BYTES to WORKER_CONTENT_MAX_BYTES
  • ensure WORKER_STORAGE_PATHS is always used in Helm

@severo
Rename obsolete mentions to datasets_based
c68df37 
- rename prefix WORKER_LOOP_ to WORKER_
- rename DATASETS_BASED_ENDPOINT to WORKER_ENDPOINT
- rename DATASETS_BASED_CONTENT_MAX_BYTES to WORKER_CONTENT_MAX_BYTES
- ensure WORKER_STORAGE_PATHS is always used in Helm
@severo severo requested review from lhoestq, AndreaFrancis and albertvillanova and removed request for lhoestq February 13, 2023 13:44
@HuggingFaceDocBuilder
Copy link
Collaborator

HuggingFaceDocBuilder commented Feb 13, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

AndreaFrancis
AndreaFrancis approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@AndreaFrancis AndreaFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks much better

@severo severo merged commit 69ce0fa into main Feb 13, 2023
@severo severo deleted the remove-mention-to-datasets-based branch February 13, 2023 14:40
@severo severo mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaFrancis AndreaFrancis AndreaFrancis approved these changes

@lhoestq lhoestq Awaiting requested review from lhoestq

@albertvillanova albertvillanova Awaiting requested review from albertvillanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@severo @HuggingFaceDocBuilder @AndreaFrancis