remove first rows fallback variable

[JatinKumar001]

Remove the FIRST_ROWS_FALLBACK_MAX_DATASET_SIZE from the code.

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[albertvillanova]

Thanks for the fix @JatinKumar001.

We are working on a related issue (thanks @severo).

• refactor: 💡 hard-code the value of the fallback #773

Once this PR is merged, could you please merge main branch into your branch?

git checkout remove-FIRST_ROWS_FALLBACK_MAX_DATASET_SIZE
git fetch upstream main
git merge upstream/main
git push -u origin remove-FIRST_ROWS_FALLBACK_MAX_DATASET_SIZE

[severo]

Thanks a lot!

One small additional change is needed, and we're good!

[severo]

Note that the CI is failing due to a temporary issue with the GitHub Actions (Azure repository of Ubuntu packages). It's not linked to the PR, and I'll relaunch the actions later, when the outage is over.

[JatinKumar001]

Hey, can you tell me what I have to do to correct these errors?

[severo]

Thanks.

For the CI errors, we have to wait until Azure fixes its repository, and then relaunch the github actions.

[albertvillanova]

We need to wait until Canonical fixes their error on their servers:

• azure.archive.ubuntu.com is unstable again actions/runner-images#7048

[severo]

To finish this PR, you should:

• merge main into your branch

    git checkout remove-FIRST_ROWS_FALLBACK_MAX_DATASET_SIZE
    git fetch upstream main
    git merge upstream/main
    git push -u origin remove-FIRST_ROWS_FALLBACK_MAX_DATASET_SIZE
  

• remove the two lines in chart/values.yaml at https://github.com/huggingface/datasets-server/blob/3bb80b725c361bb5072e14ffc82ab4838ad12405/chart/values.yaml#L285-L286

[severo]

It seems like you still have not merged the main branch of this repository into your branch. Do you want us to help with that?

[JatinKumar001]

I done it and also create a new pull request
#781

[severo]

It seems like the branch you merged into your own branch is not the current main branch.

[albertvillanova]

@JatinKumar001 please note that you don't have to open a new pull request.

You only need to push to this PR the requested changes.

I think we have fixed the problems and this PR is already OK for merging. Do you agree @severo?
EDIT: we need to fix the CI errors first. I am taking care of this.

[albertvillanova]

CI errors should be fixed first. I am taking care of this.

[severo]

Thanks @JatinKumar001 for the contribution!

And thanks @albertvillanova to make it mergeable and for finding the bug (712e871)!