Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create doc for every PR #768

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Create doc for every PR #768

merged 1 commit into from
Feb 3, 2023

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Feb 2, 2023

This is what is done in the other HF repos on github.

This way the Delete doc github action has something to delete.
If the doc doesn't exists, the job fails

@lhoestq lhoestq requested a review from severo February 2, 2023 19:23
@HuggingFaceDocBuilder
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

severo
severo approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS

@lhoestq lhoestq merged commit 7b2ef4d into main Feb 3, 2023
@lhoestq lhoestq deleted the create-doc-for-every-pr branch February 3, 2023 11:04
@lhoestq
Copy link
Member Author

lhoestq commented Feb 3, 2023

Arf the job failed anyway, will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severo severo severo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhoestq @HuggingFaceDocBuilder @severo