Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow codecov update to fail #721

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Allow codecov update to fail #721

merged 1 commit into from
Jan 30, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Jan 30, 2023

No description provided.

@severo severo changed the base branch from main to reduce-duration-backfill January 30, 2023 11:26
@severo
Copy link
Collaborator Author

severo commented Jan 30, 2023

It works: the upload failed in https://github.com/huggingface/datasets-server/actions/runs/4043352228/jobs/6952168801

[2023-01-30T11:27:59.063Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')},

but the action was marked as passed.

@severo severo merged commit a6c2968 into reduce-duration-backfill Jan 30, 2023
@severo severo deleted the allow-codecov-update-to-fail branch January 30, 2023 11:29
@severo severo mentioned this pull request Jan 30, 2023
Merged
severo added a commit that referenced this pull request Jan 30, 2023
@severo @albertvillanova
fix: 🐛 don't check if dataset is supported when we know it is (#720)
2f38593 
* fix: 🐛 don't check if dataset is supported when we know it is

* feat: 🎸 ensure the supported datasets are not private

* ci: 🎡 ignore codecov upload errors (#721)

* Update libs/libcommon/src/libcommon/dataset.py

Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>

* refactor: 💡 don't use double negations :P

* style: 💄 please black

---------

Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@severo