refactor: 💡 set libcommon as an "editable" dependency #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the jobs, services and workers share the same version of libs/libcommon, which is the current version. Before, we had to update the libcommon version, run poetry build, update the version in the other projects' pyproject.toml and poetry update it. The workflow when updating libcommon will be a lot simpler now. Also: vscode will be able to follow the reference to the source of the libcommon code, instead of showing the packaged dependency in .venv/. Caveat: this also means that now, modifying something in libcommon will affect all the jobs, services and workers, so we need to have to be more careful. This also means that more CI jobs will be run on every libcommon update, and that when deploying on prod, all the images will be updated and redeployed.
Codecov ReportBase: 90.01% // Head: 89.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
- Coverage 90.01% 89.66% -0.36%
==========================================
Files 93 78 -15
Lines 4678 3629 -1049
==========================================
- Hits 4211 3254 -957
+ Misses 467 375 -92
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the jobs, services and workers share the same version of libs/libcommon, which is the current version.
Before, we had to update the libcommon version, run poetry build, update the version in the other projects' pyproject.toml and poetry update it.
The workflow when updating libcommon will be a lot simpler now. Also: vscode will be able to follow the reference to the source of the libcommon code, instead of showing the packaged dependency in .venv/.
Caveat: this also means that now, modifying something in libcommon will affect all the jobs, services and workers, so we need to have to be more careful. This also means that more CI jobs will be run on every libcommon update, and that when deploying on prod, all the images will be updated and redeployed.