Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the workers that rely on the datasets library #656

Merged
merged 11 commits into from
Dec 1, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Dec 1, 2022

The docker image size for a worker based on the datasets library is large, mainly due to two dependencies: PyTorch and TensorFlow (about 4GB).
We create /workers/datasets_based for all the workers that depend on datasets and chose the processing step with the DATASETS_BASED_ENDPOINT env var.

@severo severo changed the title refactor: 💡 move workers/splits to workers/datasets_based Merge the workers that rely on the datasets library Dec 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Base: 85.56% // Head: 89.04% // Increases project coverage by +3.48% 🎉

Coverage data is based on head (239ffff) compared to base (4ab24c5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 239ffff differs from pull request most recent head 931d853. Consider uploading reports for the commit 931d853 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   85.56%   89.04%   +3.48%     
==========================================
  Files          54       10      -44     
  Lines        2597      639    -1958     
==========================================
- Hits         2222      569    -1653     
+ Misses        375       70     -305     
Flag Coverage Δ
jobs_mongodb_migration ?
libs_libcommon ?
services_admin ?
services_api ?
workers_datasets_based 89.04% <100.00%> (?)
workers_first_rows ?
workers_splits ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workers/datasets_based/src/datasets_based/asset.py 100.00% <ø> (ø)
workers/datasets_based/tests/fixtures/datasets.py 100.00% <ø> (ø)
...orkers/datasets_based/src/datasets_based/config.py 100.00% <100.00%> (ø)
...kers/datasets_based/src/datasets_based/features.py 73.43% <100.00%> (ø)
...orkers/datasets_based/src/datasets_based/worker.py 100.00% <100.00%> (ø)
...ets_based/src/datasets_based/workers/first_rows.py 82.87% <100.00%> (ø)
...atasets_based/src/datasets_based/workers/splits.py 97.36% <100.00%> (ø)
workers/datasets_based/tests/test_features.py 100.00% <100.00%> (ø)
...rs/datasets_based/tests/workers/test_first_rows.py 91.13% <100.00%> (ø)
...orkers/datasets_based/tests/workers/test_splits.py 89.85% <100.00%> (ø)
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severo severo force-pushed the reduce-docker-size-for-tests branch from bae06c6 to 50cb7b9 Compare December 1, 2022 10:56
@severo severo merged commit 080da2e into main Dec 1, 2022
@severo severo deleted the reduce-docker-size-for-tests branch December 1, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants