Refactor common cache entry #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.98% // Head: 91.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 84.98% 91.43% +6.44%
==========================================
Files 37 16 -21
Lines 1359 841 -518
==========================================
- Hits 1155 769 -386
+ Misses 204 72 -132
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
instead of one collection for each kind of cached entry (splits, first-rows, etc). Some admin methods have bveen disabled for now and will be reintroduced later.
The preferred way to refresh the cache is to specifically call the webhook for each dataset you want to refresh
since the cache is considered stale if the worker version or the git revision has changed.
as we only need this for now
also: rename internal method _clean_database to _clean_cache_database
needed for the splits worker
severo
force-pushed
the
refactor-common-cache-entry
branch
from
096423d
to
43252f9
Compare
just remove these lines
So that the hook will stop the update of the Helm chart. If not, the code will be updated (and expects the new database) while the database migration has failed
use variables to avoid typos
|
Migration script worked (even if it took more than the default Helm timeout for hooks -> deploy failed, without a consequence, since the migration job kept up until finished with success; I just redeployed, and the migration was skipped since already applied) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.