Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 add a stale bot #565

Merged
merged 2 commits into from
Sep 15, 2022
Merged

chore: 🤖 add a stale bot #565

merged 2 commits into from
Sep 15, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Sep 15, 2022

fixes #564

@severo severo requested a review from lhoestq September 15, 2022 13:11
lhoestq
lhoestq reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it would be useful for this project, too many issues would be closed

tools/stale.py Outdated Show resolved Hide resolved
@severo @lhoestq
Update tools/stale.py
3f6e9f4 
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@severo
Copy link
Collaborator Author

severo commented Sep 15, 2022

We can use the special tags to avoid closing some issues. And if it's proposing to close some issues, we can still answer to avoid it.
Possibly it will generate noise at the beginning, but possibly we will be happy to have it later. I think it's good to be forced to evaluate if an issue is still valid from time to time. Or am I underestimating about how much it will bother us?

@lhoestq
Copy link
Member

lhoestq commented Sep 15, 2022

What about all the existing issues ? You want to tag them to choose which one to keep ?

@severo
Copy link
Collaborator Author

severo commented Sep 15, 2022

Only let the bot tag comment on them, and then evaluate them one by one, and answer to keep them open if needed (most of the cases).
But if you think that it's a loss of time, we can also close this PR.

@lhoestq
Copy link
Member

lhoestq commented Sep 15, 2022

As you want

@severo severo merged commit 1c0b091 into main Sep 15, 2022
@severo severo deleted the add-stale-bot branch September 15, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install a stale bot
2 participants
@severo @lhoestq