Add timestamp type #374
Merged
Add timestamp type #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also create some silly tests to show how to use them
Note that the column types are still defined in service/worker. Once we upgrade libutils to this version in worker, we will use this definition instead. The idea is that libutils is the source of truth for types and enums.
rebuild with update of the dependencies
upgrades libutils and other dependencies
upgrade libutils and other dependencies
there is no reason for having two files, as the functions of typed_row.py are only used in split.py
because DOCKER_IMAGES is generally not defined
Note: it would be good to DRY, but I don't know how to get the union of the literals from the enum
Now, the type of every column is checked better, and the code is a bit simpler.
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #371 that I accidentally closed instead of merging