Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more explicit about the current docker images #346

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Be more explicit about the current docker images #346

merged 6 commits into from
Jun 3, 2022

Commits on Jun 3, 2022

  1. ci: 🎡 fix path

    @severo
    severo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b2d5b4b View commit details
    Browse the repository at this point in the history

  2. ci: 🎡 try to fix the issue with env 

    See
https://github.com/huggingface/datasets-server/actions/runs/2433883992
    @severo
    severo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b941828 View commit details
    Browse the repository at this point in the history

  3. ci: 🎡 allow to manually launch the workflows

    @severo
    severo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    1bd6585 View commit details
    Browse the repository at this point in the history

  4. ci: 🎡 don't use env at "job" level 

    the env can only be used at "step" level: see
https://github.community/t/how-to-set-and-access-a-workflow-variable/17335/6
    @severo
    severo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b262045 View commit details
    Browse the repository at this point in the history

  5. fix: 🐛 add a default value, overriden by docker-images.yaml

    @severo
    severo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    7705991 View commit details
    Browse the repository at this point in the history

  6. ci: 🎡 try to fix the config loading from a file 

    I have the intuition it comes from the "working dir" in the second job,
which is why I created a previous job at the root
    @severo
    severo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    598f694 View commit details
    Browse the repository at this point in the history