Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx proxy #245

Merged
merged 4 commits into from
May 11, 2022
Merged

Nginx proxy #245

merged 4 commits into from
May 11, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented May 11, 2022

No description provided.

@severo severo requested a review from XciD May 11, 2022 12:41
Copy link
Member

@XciD XciD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@severo severo merged commit 9dcaa09 into main May 11, 2022
@severo severo deleted the nginx-proxy branch May 11, 2022 14:13
@severo
Copy link
Collaborator Author

severo commented May 11, 2022

Fixes #234

mattstern31 added a commit to mattstern31/datasets-server-storage-admin that referenced this pull request Nov 11, 2023
* refactor: 💡 use a temporal name for the directory

* refactor: 💡 the mount path is relevant only for the container

* feat: 🎸 add nginx as a reverse proxy

* refactor: 💡 use the domain service instead of environment vars

See
huggingface/dataset-viewer#245 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants