split the code and move to a monorepo #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It prepares the split into services
Closed
see https://stackoverflow.com/a/54392358/7351594. It makes clearer which python version is needed to run the apps
It's a trick to avoid the following error: https://github.com/huggingface/datasets-preview-backend/runs/6196224496?check_suite_focus=true. Having all the packages at the same level allows to remove the error: "Directory ../libmodels does not exist" that appears with the transitive local dependencies (ie: job_runner <- libmodels <- libutils)
severo
changed the title
If you open the workspace .vscode/monorepo.code-workspace in VSCode, every lib and service will be displayed in its own "folder", and everyone will use the Python interpreter of its own .env. Also: move vendors/ to the root, to let libs/ only for our libraries.
severo
changed the title
use the monorepo workspace in .vscode instead
severo
force-pushed
the
split-into-three-packages
branch
from
e3f9a0e
to
2c4168e
Compare
severo
force-pushed
the
split-into-three-packages
branch
from
2c4168e
to
a8fa1c8
Compare
also: add get_str_list_value util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203